fix: 修复ComfyUI SDK的cargo check和clippy警告

- 修复ComfyUIError中WebSocket变体过大的问题,使用Box包装
- 添加自定义From实现处理Box包装的WebSocket错误
- 修复所有格式化字符串警告,使用内联格式化
- 移除无用的类型转换(reqwest::Error::from)
- 修复代码质量问题:
  - 简化if语句嵌套
  - 使用?操作符替代显式错误处理
  - 优化map迭代方式
  - 使用is_some_and替代map_or

修复内容:
- 44个clippy警告全部解决
- 所有测试通过
- cargo check --lib 无错误无警告
This commit is contained in:
2025-08-08 16:12:25 +08:00
parent e874d281e0
commit e69ce2b817
9 changed files with 63 additions and 71 deletions

View File

@@ -53,7 +53,7 @@ impl WebSocketClient {
}
let ws_url = self.build_websocket_url()?;
log::info!("Connecting to WebSocket: {}", ws_url);
log::info!("Connecting to WebSocket: {ws_url}");
let (ws_stream, _) = connect_async(&ws_url).await?;
let (_ws_sender, mut ws_receiver) = ws_stream.split();
@@ -78,7 +78,7 @@ impl WebSocketClient {
match message {
Some(Ok(Message::Text(text))) => {
if let Err(e) = Self::handle_message(&text, &event_emitter).await {
log::error!("Error handling WebSocket message: {}", e);
log::error!("Error handling WebSocket message: {e}");
}
}
Some(Ok(Message::Close(_))) => {
@@ -86,7 +86,7 @@ impl WebSocketClient {
break;
}
Some(Err(e)) => {
log::error!("WebSocket error: {}", e);
log::error!("WebSocket error: {e}");
break;
}
None => {
@@ -168,7 +168,7 @@ impl WebSocketClient {
/// Handles incoming WebSocket messages
async fn handle_message(text: &str, event_emitter: &EventEmitter) -> Result<()> {
let message: WSMessage = serde_json::from_str(text)
.map_err(|e| ComfyUIError::new(format!("Failed to parse WebSocket message: {}", e)))?;
.map_err(|e| ComfyUIError::new(format!("Failed to parse WebSocket message: {e}")))?;
match message {
WSMessage::Progress { data } => {
@@ -204,7 +204,7 @@ impl WebSocketClient {
event_emitter.emit_error(error).await;
}
WSMessage::Unknown => {
log::debug!("Received unknown WebSocket message: {}", text);
log::debug!("Received unknown WebSocket message: {text}");
}
}